AVRO-4115: [PHP] Fix long encoding #3303
Open
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thiagorb @MichelHartmann can you guys take a look at this please? |
|
Looks good to me! |
thiagorb
approved these changes
Feb 6, 2025
thiagorb
approved these changes
Feb 6, 2025
martin-g
reviewed
Feb 7, 2025
|
@martin-g can you take a look again please? I decided to keep the original methods instead of creating a new file, the diff looks better now. |
thiagorb
approved these changes
Feb 10, 2025
|
@adamquaile @valvadis @jjatria @skystebnicki You might be interested to review this change |
jonhkr
force-pushed
the
main
branch
2 times, most recently
from
aea815f to
4ca2932
Compare
|
@martin-g there was a small typo in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes PHP long encoding on 64bit platforms as the current implementation does not support longs bigger than
1<<61.Verifying this change
I've added new tests to cover more scenarios and uncommented existing tests.
https://issues.apache.org/jira/browse/AVRO-4115